projects/file-explorer
projects/file-explorer
1
0
Fork 1
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Implement image previewing #12

Merged
csimonis merged 7 commits from jank1619/file-explorer:feature/file-previews into main 2024-12-21 18:12:14 +00:00
Conversation 1 Commits 7 Files Changed 5 +212 -4
jank1619 commented 2024-12-21 13:50:19 +00:00
Contributor
Copy Link

I have tested this with png and jpeg/jpg which both work but most other image types should work as well.
image

I have tested this with png and jpeg/jpg which both work but most other image types should work as well. ![image](/attachments/25318577-d48c-4902-93b3-9adbb8b954e7)
image.png
568 KiB
jank1619 added 4 commits 2024-12-21 13:50:19 +00:00 
Reviewed-on: jank1619/file-explorer#1
style(home.html.twig): adjust centering of container element (#2)
All checks were successful
build / build (pull_request) Successful in 5m19s
Details
c1e1ab081f 
Co-authored-by: Jan Klattenhoff <j.klattenhoff@neusta.de>
Reviewed-on: jank1619/file-explorer#2
Reviewed-on: jank1619/file-explorer#3
jank1619 added 2 commits 2024-12-21 16:11:06 +00:00
jank1619 changed title from WIP: Implement file previewing to WIP: Implement image previewing 2024-12-21 16:11:36 +00:00
jank1619 changed title from WIP: Implement image previewing to Implement image previewing 2024-12-21 16:12:39 +00:00
jank1619 requested review from csimonis 2024-12-21 16:14:33 +00:00
csimonis requested changes 2024-12-21 16:38:35 +00:00
src/Controller/ServeFileController.php Outdated
@ -0,0 +14,4 @@
{
}
#[Route("/serve-file/{filePath}", name: "serve_file")]
csimonis commented 2024-12-21 16:37:57 +00:00
Owner
Copy Link

can you change route to /serve/filepath

can you change route to /serve/filepath
jank1619 marked this conversation as resolved
jank1619 added 1 commit 2024-12-21 17:37:07 +00:00
Update src/Controller/ServeFileController.php
All checks were successful
build / build (pull_request) Successful in 4m19s
Details
d6aefc423c
csimonis merged commit a67b93ac99 into main 2024-12-21 18:12:14 +00:00
csimonis deleted branch feature/file-previews 2024-12-21 18:12:15 +00:00
csimonis referenced this issue from a commit 2024-12-21 18:12:15 +00:00
Implement image previewing
Sign in to join this conversation.
Reviewers
No Reviewers
csimonis
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
csimonis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: projects/file-explorer#12
No description provided.
Delete Branch "jank1619/file-explorer:feature/file-previews"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?